dekaf: Expire Reads after 5m
#1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
There was a problem hiding this comment.
what's the mechanism by which this session will grab an entirely new gazette::Router (e.g. new underlying connection) for the next started read?
There was a problem hiding this comment.
I was thinking that the call to authenticated_client() always created a new gazette client, but it turns out it only does when refreshing the access token, reducing the effective Read timeout to however long access tokens live for (an hour I think).
I updated the fetch() handler to explicitly call client.with_fresh_gazette_client() upon Read timeout. We could also go nuclear and have authenticated_client() always return a client with fresh router, but that seemed like it might be unnecessary. Thoughts?
We saw problems before where something about a `journal::Client` would stop responding after some amount of time in use. We were seeing issues where consumers would stop seeing updates to journals after a certain amount of time, and I just realized that it's possible for a `Read` (which contains a `journal::Client`) to live for a long time. This times out a `Read` after 5 minutes, so it get a new `journal::Client`, and hopefully bypasses the issue.
jshearer
force-pushed
the
jshearer/dekaf_expire_reads
branch
from
9e1ca03
to
55b43a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We saw problems before where something about a
journal::Clientwould stop responding after some amount of time in use. We were seeing issues where consumers would stop seeing updates to journals after a certain amount of time, and I just realized that it's possible for aRead(which contains ajournal::Client) to live for a long time. This times out aReadafter 5 minutes, so it get a newjournal::Client, and hopefully bypasses the issue.Tested locally with
kcat, will test indekaf-devwhen build passesThis change is