Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison matrix improvements #663

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Brenosalv
Copy link
Collaborator

#643

Changes

  • Make comparison table collapsible;
  • Add and remove some comparison contents.

@Brenosalv Brenosalv added the enhancement New feature or request label Feb 3, 2025
@Brenosalv Brenosalv self-assigned this Feb 3, 2025
@Brenosalv Brenosalv linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 3, 2025

Visit the preview URL for this PR (updated for commit d150ce2):

https://estuary-marketing--pr663-brenosalv-feature-64-p0fmiopj.web.app

(expires Thu, 06 Mar 2025 08:10:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@Brenosalv Brenosalv requested a review from travjenkins February 4, 2025 05:25
@Brenosalv Brenosalv marked this pull request as ready for review February 4, 2025 05:25
: {};
<tr>
<td colSpan={4} className={collapseWrapper}>
<Collapse in={expandTableSection} timeout="auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to set the component on 'Collapse` to reduce nesting.

Something like:

<td colSpan={4} className={collapseWrapper}>
    <Collapse in={expandTableSection} timeout="auto" component="table">
        <tbody>...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a chance this won't work though... cause collapsing tables has been a pain before.

Copy link
Collaborator Author

@Brenosalv Brenosalv Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had to do this nesting because the table elements like <table>, <td>, etc. don't accept divs as children. Setting component prop as table makes a table has a div as child, so it doesn't work:

image

Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - we'll wait for all content to be filled into Strapi before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison Matrix improvements
2 participants