-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison matrix improvements #663
base: master
Are you sure you want to change the base?
Comparison matrix improvements #663
Conversation
Visit the preview URL for this PR (updated for commit d150ce2): https://estuary-marketing--pr663-brenosalv-feature-64-p0fmiopj.web.app (expires Thu, 06 Mar 2025 08:10:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
: {}; | ||
<tr> | ||
<td colSpan={4} className={collapseWrapper}> | ||
<Collapse in={expandTableSection} timeout="auto"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to set the component
on 'Collapse` to reduce nesting.
Something like:
<td colSpan={4} className={collapseWrapper}>
<Collapse in={expandTableSection} timeout="auto" component="table">
<tbody>...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a chance this won't work though... cause collapsing tables has been a pain before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - we'll wait for all content to be filled into Strapi before merging.
#643
Changes