Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the journals not found data preview alert #1424

Merged

Conversation

kiahna-tucker
Copy link
Member

@kiahna-tucker kiahna-tucker commented Jan 17, 2025

Issues

The issues directly below are completely resolved by this PR:
#1412

Changes

1412

The following features are included in this PR:

  • Update the journals not found alert data preview alert for collections. The content includes a Sources Page CTA will redirect the user to the Captures page. The CTA label is determined by the route title.

  • Create a derivation-applicable version of the collection journals not found alert message.

Tests

Manually tested

Approaches to testing are as follows:

  • Validate that the collection-specific journals not found alert functions as intended.

  • Validate that the collection-specific journals not found alert does not appear in the Data Preview section of a derivation Details page.

Automated tests

N/A

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Journals not found alert | Data Preview section of collection Details page

pr_screenshot-1418-data_preview_error-collection

Journals not found alert | Data Preview section of derivation Details page

pr_screenshot-1418-data_preview_error-derivation

@kiahna-tucker kiahna-tucker added the change:planned This is a planned change label Jan 17, 2025
@kiahna-tucker kiahna-tucker marked this pull request as ready for review January 17, 2025 15:55
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner January 17, 2025 15:55
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins travjenkins merged commit 2715060 into main Jan 21, 2025
3 checks passed
@travjenkins travjenkins deleted the kiahna-tucker/ux-tweaks/update-journals-not-found-alert branch January 21, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:planned This is a planned change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants