Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing the binding filter to be cleared #828

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Allowing the binding filter to be cleared #828

merged 1 commit into from
Nov 21, 2023

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Nov 15, 2023 •
edited
Loading

Issues

Fixes #827

Changes

827

  • Add a reusable adornment for clearing inputs
  • Add the adornment to the bindings filter header

Tests

Manually tested

  • Lots of fussing around with entering values, clearing field, making it disabled/enabled

Screenshots

Screenshot_20231116-085542

@travjenkins travjenkins marked this pull request as ready for review November 16, 2023 13:56
@travjenkins travjenkins requested a review from a team as a code owner November 16, 2023 13:56
@travjenkins travjenkins merged commit 83956f9 into main Nov 21, 2023
3 checks passed
@travjenkins travjenkins deleted the travjenkins/takeOutRemoveAll branch November 21, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The bindings selector "remove all" functionality is confusing
2 participants
@travjenkins @kiahna-tucker