Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sharable findBindingIndex function for field selection #831

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Create sharable findBindingIndex function for field selection #831

merged 2 commits into from
Nov 28, 2023

Conversation

travjenkins
Copy link
Member

Issues

#830

Changes

830

  • Use new function so that the binding index will be found even when time travel props are set

Misc

  • Make a util function to fetch the binding index

Tests

Manually tested

  • Materialization create/edit

Screenshots

Nothing to really screenshot in terms of the changes a user would notice... but:

  1. Switched to disabled
  2. The time travel was already set
  3. The network calls were made to update the draft properly
    image

@travjenkins travjenkins marked this pull request as ready for review November 28, 2023 15:04
@travjenkins travjenkins requested a review from a team as a code owner November 28, 2023 15:04
@travjenkins travjenkins merged commit 31c2971 into main Nov 28, 2023
3 checks passed
@travjenkins travjenkins deleted the travjenkins/fieldSelectionTimeTravel branch November 28, 2023 16:53
@travjenkins travjenkins mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker