code review: no default argument for function

etalab · Feb 5, 2025 · 7c98fd5 · 7c98fd5
1 parent 8914b92
commit 7c98fd5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/apps/transport/lib/transport/preemptive_api_cache.ex b/apps/transport/lib/transport/preemptive_api_cache.ex
@@ -7,7 +7,6 @@ defmodule Transport.PreemptiveAPICache do
     first_run: 0,
     job_delay: :timer.seconds(300),
     # more than twice job_delay to reduce the risk of parallel computation
-
     cache_ttl: :timer.seconds(700)
 
   require Logger

diff --git a/apps/transport/lib/transport/preemptive_base_cache.ex b/apps/transport/lib/transport/preemptive_base_cache.ex
@@ -36,12 +36,12 @@ defmodule Transport.PreemptiveBaseCache do
         {:ok, state}
       end
 
-      def schedule_next_occurrence(delay \\ @job_delay) do
+      def schedule_next_occurrence(delay) do
         Process.send_after(self(), :tick, delay)
       end
 
       def handle_info(:tick, state) do
-        schedule_next_occurrence()
+        schedule_next_occurrence(@job_delay)
         populate_cache()
         {:noreply, state}
       end