Name constants with a leading "k" and mixed case #140
Conversation
A C++ programming convention, also suggested by the [Google style guide](https://google.github.io/styleguide/cppguide.html#Constant_Names) and enforced by `cpplint`, is to name variables declared `constexpr` or `const`, and whose value is fixed for the duration of the program, by a leading "k" followed by mixed case. There are only two files that require changes, one in the main source, which may require some discussion, and one in the test suite, which is uncontroversial, I think. This commit fixes both of them.
There was a problem hiding this comment.
I've mentioned one case inline as an example, but in general I am not sure why this should not apply to all static/global const-declared variables in that case?
I think there are quite a few more that violate this code standard should we adopt it (which is perhaps the real question?).
| @@ -30,7 +30,7 @@ constexpr std::size_t size = 1<<20; | |||
| constexpr std::size_t cache_size = size; | |||
|
|
|||
| /** @brief number of threads to spawn for some of the tests */ | |||
| constexpr int nThreads = 16; | |||
| constexpr int kThreads = 16; | |||
| /** @brief number of itereations to run for some of the tests */ | |||
| constexpr int iter = 10000; | |||
There was a problem hiding this comment.
I fail to understand what the difference between L33 and L35 is?
It seems to me that if one adopts the kMixedCase convention, should this not apply to both?
|
My guess is that the NB: In case you did not notice this already, the |
A C++ programming convention, also suggested by the Google style guide and enforced by
cpplint, is to name variables declaredconstexprorconst, and whose value is fixed for the duration of the program, by a leading "k" followed by mixed case.There are only two files that require changes, one in the main source, which may require some discussion, and one in the test suite, which is uncontroversial, I think. This commit fixes both of them.