WIP: Add password and db to SentinelMonitoredRedisClientMasterSlaves #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJFliX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: My changes do not seem to have any effect. I'll work on the pull request to fix it.
Hi! I used this library to select a database after creating the SentinelMonitoredRedisClientMasterSlaves. Unfortunately I noticed that the slaves ignore the db and auth value. This means that if I update something on my staging server (separate db) it is not changed on the database where I read from. This is slightly frustrating :).
The changes should not stand in anyones way and as far as my Scala knowledge goes this would solve my problem.