Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot API 7.6 #2329

Merged
merged 10 commits into from
Jul 4, 2024
Merged

Bot API 7.6 #2329

merged 10 commits into from
Jul 4, 2024

Conversation

coder2020official
Copy link
Collaborator

@coder2020official coder2020official commented Jul 1, 2024

@coder2020official coder2020official marked this pull request as ready for review July 1, 2024 18:14
@coder2020official
Copy link
Collaborator Author

@Badiboy done with the update i think, need your review

@Badiboy
Copy link
Collaborator

Badiboy commented Jul 1, 2024

Will take a look

@Badiboy
Copy link
Collaborator

Badiboy commented Jul 3, 2024

To the review (in progress):

convert_input_media_array should also isinstance the InputPaidMedia

telebot/types.py Outdated
data = super().to_dict()
if self.thumbnail:
data['thumbnail'] = self.thumbnail.to_dict()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbnail is "InputFile or String"

Should be

if self.thumbnail:
data['thumbnail'] = self.thumbnail

telebot/types.py Outdated
def to_dict(self):
data = {}
data['type'] = str(self.type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why (str) is here?

telebot/types.py Outdated
data = {}
data['type'] = str(self.type)
data['media'] = str(self.media)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why (str) is here?

telebot/types.py Outdated
if self.duration:
data['duration'] = self.duration
if self.supports_streaming:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if self.supports_streaming is not None:

@Badiboy
Copy link
Collaborator

Badiboy commented Jul 3, 2024

need your review

Done.

@coder2020official
Copy link
Collaborator Author

@Badiboy fixed your addressed points. Also, manually tested the send_paid_media method - it worked after changing InputPaidMedia to behave like InputMedia

@Badiboy Badiboy merged commit 134fda7 into eternnoir:master Jul 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants