Skip to content

Commit

Permalink
remove "file://" from envvar (#45)
Browse files Browse the repository at this point in the history
There was another instance of `file://` in the code, the plugin exported the image path using `file://` prefix. Causing subsequent srun to fail.

This has been fixed already #44. 

The current PR removes the inconsistent setting of UENV_MOUNT_LIST. `squashfs-mount` omits `file://`.
  • Loading branch information
simonpintarelli authored May 31, 2024
1 parent 1f0ca80 commit 63279e1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ int init_post_opt_remote(spank_t sp,
for (auto &entry : mount_entries) {
auto abs_image = *util::realpath(entry.image_path);
auto abs_mount = *util::realpath(entry.mount_point);
env_var += "file://" + abs_image + ":" + abs_mount + ",";
env_var += abs_image + ":" + abs_mount + ",";
}
if (mount_entries.size() > 0) {
spank_setenv(sp, UENV_MOUNT_LIST, env_var.c_str(), 1);
Expand Down

0 comments on commit 63279e1

Please sign in to comment.