-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: super root withdrawal proofs #205
Conversation
5ec893e
to
20c2b56
Compare
Review notes
|
Introduces a proposal to include super root validation logic inside of the base optimism portal contract.
9b7ce08
to
f529541
Compare
Launch sequence is described in this separate design doc: #207 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this proposal, and it should still be able to use all of the logic from my PR.
Good catch on including the chain ID in the portal.
I'd still like for us to explore using the game type as the activation method for the proof verification functionality. It feels much nicer for this to be implicitly activated, rather than having to switch the game type + explicitly activate super root verification. We never ran into this need because we've never switched the format of the output root before, but being able to have games declare their withdrawal inclusion proof verification function is beneficial.
If we don't want to do that, this should still be fine, and we can always upgrade to that later.
Introduces a proposal to include super root validation logic inside of the base optimism portal contract.