Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: super root withdrawal proofs #205

Merged
merged 5 commits into from
Feb 22, 2025
Merged

Conversation

smartcontracts
Copy link
Contributor

Introduces a proposal to include super root validation logic inside of the base optimism portal contract.

@smartcontracts
Copy link
Contributor Author

smartcontracts commented Feb 20, 2025

Review notes

  • Include sequencing of events in the design doc
  • Maybe consider switching methods based on game type
  • MUST have Chain ID in the Portal to prevent x-chain withdrawals
  • Strong preference that everyone is using Super Roots ASAP

Introduces a proposal to include super root validation logic
inside of the base optimism portal contract.
@smartcontracts
Copy link
Contributor Author

Launch sequence is described in this separate design doc: #207

Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this proposal, and it should still be able to use all of the logic from my PR.

Good catch on including the chain ID in the portal.

I'd still like for us to explore using the game type as the activation method for the proof verification functionality. It feels much nicer for this to be implicitly activated, rather than having to switch the game type + explicitly activate super root verification. We never ran into this need because we've never switched the format of the output root before, but being able to have games declare their withdrawal inclusion proof verification function is beneficial.

If we don't want to do that, this should still be fine, and we can always upgrade to that later.

@smartcontracts smartcontracts merged commit df86e6c into main Feb 22, 2025
@smartcontracts smartcontracts deleted the sc/generic-wd-proofs branch February 22, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants