Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better handling of keeping pre installed contract address in sync with docs #154

Closed
jakim929 opened this issue Sep 18, 2024 · 1 comment
Closed

better handling of keeping pre installed contract address in sync with docs #154

jakim929 opened this issue Sep 18, 2024 · 1 comment

Comments

@jakim929
Copy link
Contributor

since we use CREATE2 for L2NativeSuperchainERC20, when the monorepo contract dependencies are updated, the addresses change too. causes drift between docs & implementation

some options:

  • set up automation to update contract address
  • deploy behind a proxy so address never changes
This was referenced Sep 18, 2024
Merged
Closed
@tremarkley tremarkley mentioned this issue Sep 23, 2024
Merged
@jakim929
Copy link
Contributor Author

closed with #169. We should continue to use this pattern of proxy at special ddresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakim929