Update EIP-2537: Remove MUL precompiles #8945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
File
|
This removes `BLS12_G1MUL` and `BLS12_G2MUL` precompiles because they are trivially replaceable by corresponding MSM precompiles. This reduces the number of precompile's addresses defined in this EIP from 9 to 7. The addresses of remaining 7 precompiles are changed to be continues. The Rationale entry describes why this change make sense. Additionally, the cost of MSM for single input (`k==1`) has been corrected to match the original MUL cost. The specification now suggests how this case should be implemented. Morever, because of the ABI compatibility between MUL and MSM all existing tests for MULs can be easily converted to tests for MSMs. The PoC of MUL and MSM precompiles equivalence is provided in [evmone PR#1042](ethereum/evmone#1042).
chfast
force-pushed
the
eip2537/remove_muls
branch
from
bfa6096
to
40cc72d
Compare
|
I think we have historically preferred to not overload precompiles like this, but I'd love to hear what others think |
cygnusv
reviewed
Oct 12, 2024
| | BLS12_G2MSM | 0x0e | precompile address | | ||
| | BLS12_PAIRING_CHECK | 0x0f | precompile address | | ||
| | BLS12_MAP_FP_TO_G1 | 0x10 | precompile address | | ||
| | BLS12_MAP_FP2_TO_G2 | 0x11 | precompile address | | ||
|
|
||
| If `block.timestamp >= FORK_TIMESTAMP` we introduce *nine* separate precompiles to perform the following operations: |
There was a problem hiding this comment.
Suggested change
| If `block.timestamp >= FORK_TIMESTAMP` we introduce *nine* separate precompiles to perform the following operations: | |
| If `block.timestamp >= FORK_TIMESTAMP` we introduce *seven* separate precompiles to perform the following operations: |
|
not sure as well, it's kind of matter of taste here. At this point we could even remove |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
BLS12_G1MULandBLS12_G2MULprecompiles because they are trivially replaceable by corresponding MSM precompiles.This reduces the number of precompile's addresses defined in this EIP from 9 to 7. The addresses of remaining 7 precompiles are changed to be continues.
The Rationale entry describes why this change make sense. Additionally, the cost of MSM for single input (
k==1) has been corrected to match the original MUL cost. The specification now suggests how this case should be implemented.Morever, because of the ABI compatibility between MUL and MSM all existing tests for MULs can be easily converted to tests for MSMs.
The PoC of MUL and MSM precompiles equivalence is provided in evmone PR#1042.
The adjustment of the MSM implementation for single input in evmone PR#1046.