Update EIP-7761: Change HASCODE to EXTCODETYPE #9229
Merged
+60
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the EIP to return the type of the account (EOA, Legacy Code, EOFv1 code) instead of a boolean has/no code. Expand upon these decisions in the rationale and motivation.
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
|
The commit aa8f602 (as a parent of 79737db) contains errors. |
frangio
reviewed
Jan 10, 2025
frangio
reviewed
Jan 10, 2025
rezaeghbal01
approved these changes
Jan 17, 2025
gumb0
reviewed
Jan 23, 2025
gumb0
reviewed
Jan 23, 2025
gumb0
reviewed
Jan 23, 2025
gumb0
reviewed
Jan 23, 2025
gumb0
reviewed
Jan 23, 2025
|
|
||
| One potential solution to this would be to have a generalized `CONTRACT_KIND` instruction instead of `HASCODE` which would further discriminate the account into legacy or EOFv1 with a `0` / `1` / `2` return value, thereby providing means for an additional safeguard against such a scenario. | ||
| In parallel to the ERC-721 / ERC-1155 problem, another potential risk has been brought to attention. Since EOFv1 prohibits `EXTDELEGATECALL` targeting legacy contracts, there exists a scenario where an EOF proxy contract accidentally upgrades its implementation to a legacy EVM one. Since reverting this or upgrading again (using current proxy standards) requires the implementation contract to be called, it would effectively render the contract unusable. |
There was a problem hiding this comment.
Imho this explanation would be nice to have in Motivation
There was a problem hiding this comment.
It is in the motivation, line 25, just not with the full technical drill down.
Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Andrei Maiboroda <[email protected]>
eth-bot
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the EIP to return the type of the account (EOA, Legacy Code, EOFv1 code) instead of a boolean has/no code.
Expand upon these decisions in the rationale and motivation.
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: