Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Vyper upgrades, etc #165

Merged
merged 7 commits into from
Jun 7, 2018
Merged

Vyper upgrades, etc #165

merged 7 commits into from
Jun 7, 2018

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 5, 2018

Addresses #153, #138

What I did

  • upgrade vyper to recent commit
    • custom units
    • change int128 to uint256 for all non-negative integers
    • no vyper support for convert (uint256 -> decimal) yet so there are a lot of (uint256 -> int128 -> decimal) converts for the time being
  • deploy contract via irregular state change in testing
    • contract size exceeds EIP170 limits
    • good sample code for future py-evm implementation
  • vyper currently drops units when doing a convert
  • Tests were about 10x slower when we used eth-tester==0.1.0b26 && py-evm==0.2.0a18. Downgraded to eth-tester==0.1.0b24 && py-evm==0.2.0a16 and performance went back to normal.
  • upgrade web3.py to 4.3.0

@djrtwo djrtwo requested a review from ChihChengLiang June 6, 2018 14:43
@djrtwo djrtwo changed the title [WIP] Vyper upgrades, etc Vyper upgrades, etc Jun 6, 2018
@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 6, 2018

A couple of build errors. Fixing now

@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 6, 2018

fixed. ready for review

Copy link
Contributor

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that wei_value and uint256(wei) are using interchangeably in the codebase. wei_value looks prettier while uint256(wei) provides more detail when tracing the convert.
The rest looks great!

@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 7, 2018

You're right. I'm switching everything to wei_value for now.

@djrtwo djrtwo merged commit a49f302 into ethereum:master Jun 7, 2018
@djrtwo djrtwo deleted the custom-units branch June 7, 2018 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants