Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadCN]: Migrate Base Simulator Content #14750

Merged
merged 16 commits into from
Jan 31, 2025
Merged

[ShadCN]: Migrate Base Simulator Content #14750

merged 16 commits into from
Jan 31, 2025

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Jan 27, 2025 •
edited
Loading

Description

Migrates base components for the main Simulator component to Tailwind/ShadCN

@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b16fd03
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6799a463969e3900084b3518
😎 Deploy Preview https://deploy-preview-14750--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 47 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer force-pushed the feat/simulator-main-shadcn branch 2 times, most recently from 0b1f1f2 to 8c14ede Compare January 28, 2025 03:08
@TylerAPfledderer TylerAPfledderer force-pushed the feat/simulator-main-shadcn branch from 8c14ede to 6af63f5 Compare January 28, 2025 03:11
@TylerAPfledderer TylerAPfledderer force-pushed the feat/simulator-main-shadcn branch from ef07a88 to cf8711b Compare January 28, 2025 03:28
@TylerAPfledderer TylerAPfledderer force-pushed the feat/simulator-main-shadcn branch from 4e8a8dc to 4d20859 Compare January 29, 2025 02:25
@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review January 29, 2025 03:48
@TylerAPfledderer TylerAPfledderer changed the title [WIP][ShadCN]: Migrate Base Simulator Content [ShadCN]: Migrate Base Simulator Content Jan 29, 2025
@nloureiro
Copy link
Contributor

All looks good from my side. grat work @TylerAPfledderer :)

pettinarip
pettinarip approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @TylerAPfledderer gj

@pettinarip pettinarip merged commit 36bb7f2 into ethereum:dev Jan 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nloureiro nloureiro nloureiro approved these changes

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerAPfledderer @nloureiro @pettinarip