Merge pull request #577 from ethereum/warnings

Add stricter settings for warnings
ethereum · Mar 23, 2021 · 1132bd6 · 1132bd6
2 parents 9bf701b + 5794a34
commit 1132bd6
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 11 deletions.
diff --git a/examples/example_host.cpp b/examples/example_host.cpp
@@ -20,6 +20,8 @@ namespace evmc
 {
 struct account
 {
+    virtual ~account() = default;
+
     evmc::uint256be balance = {};
     std::vector<uint8_t> code;
     std::map<evmc::bytes32, evmc::bytes32> storage;

diff --git a/include/evmc/evmc.h b/include/evmc/evmc.h
@@ -28,7 +28,7 @@
 #include <stddef.h>  /* Definition of size_t. */
 #include <stdint.h>  /* Definition of int64_t, uint64_t. */
 
-#if __cplusplus
+#ifdef __cplusplus
 extern "C" {
 #endif
 
@@ -917,7 +917,7 @@ struct evmc_vm
 
 /* END Python CFFI declarations */
 
-#if EVMC_DOCUMENTATION
+#ifdef EVMC_DOCUMENTATION
 /**
  * Example of a function creating an instance of an example EVM implementation.
  *
@@ -936,7 +936,7 @@ struct evmc_vm
 struct evmc_vm* evmc_create_example_vm(void);
 #endif
 
-#if __cplusplus
+#ifdef __cplusplus
 }
 #endif
 

diff --git a/include/evmc/instructions.h b/include/evmc/instructions.h
@@ -16,7 +16,7 @@
 #include <evmc/evmc.h>
 #include <evmc/utils.h>
 
-#if __cplusplus
+#ifdef __cplusplus
 extern "C" {
 #endif
 
@@ -219,7 +219,7 @@ EVMC_EXPORT const struct evmc_instruction_metrics* evmc_get_instruction_metrics_
  */
 EVMC_EXPORT const char* const* evmc_get_instruction_names_table(enum evmc_revision revision);
 
-#if __cplusplus
+#ifdef __cplusplus
 }
 #endif
 

diff --git a/include/evmc/loader.h b/include/evmc/loader.h
@@ -14,7 +14,7 @@
  */
 #pragma once
 
-#if __cplusplus
+#ifdef __cplusplus
 extern "C" {
 #endif
 
@@ -161,9 +161,9 @@ struct evmc_vm* evmc_load_and_configure(const char* config,
  * @return Error message or NULL if no additional information is available.
  *         The returned pointer MUST NOT be freed by the caller.
  */
-const char* evmc_last_error_msg();
+const char* evmc_last_error_msg(void);
 
-#if __cplusplus
+#ifdef __cplusplus
 }
 #endif
 

diff --git a/include/evmc/utils.h b/include/evmc/utils.h
@@ -27,7 +27,7 @@
  * @def EVMC_NOEXCEPT
  * Safe way of marking a function with `noexcept` C++ specifier.
  */
-#if __cplusplus
+#ifdef __cplusplus
 #define EVMC_NOEXCEPT noexcept
 #else
 #define EVMC_NOEXCEPT

diff --git a/lib/loader/loader.c b/lib/loader/loader.c
@@ -15,7 +15,7 @@
 
 #if defined(EVMC_LOADER_MOCK)
 #include "../../test/unittests/loader_mock.h"
-#elif _WIN32
+#elif defined(_WIN32)
 #include <Windows.h>
 #define DLL_HANDLE HMODULE
 #define DLL_OPEN(filename) LoadLibrary(filename)
@@ -136,7 +136,7 @@ evmc_create_fn evmc_load(const char* filename, enum evmc_loader_error_code* erro
 
     // Find filename in the path.
     const char* sep_pos = strrchr(filename, '/');
-#if _WIN32
+#ifdef _WIN32
     // On Windows check also Windows classic path separator.
     const char* sep_pos_windows = strrchr(filename, '\\');
     sep_pos = sep_pos_windows > sep_pos ? sep_pos_windows : sep_pos;