baseline: disable jumpdest analysis

ethereum · Jun 6, 2024 · 47ec33c · 47ec33c
1 parent a66479f
commit 47ec33c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/evmone/baseline.cpp b/lib/evmone/baseline.cpp
@@ -26,7 +26,7 @@ namespace evmone::baseline
 {
 namespace
 {
-CodeAnalysis::JumpdestMap analyze_jumpdests(bytes_view code)
+[[maybe_unused]] CodeAnalysis::JumpdestMap analyze_jumpdests(bytes_view code)
 {
     // To find if op is any PUSH opcode (OP_PUSH1 <= op <= OP_PUSH32)
     // it can be noticed that OP_PUSH32 is INT8_MAX (0x7f) therefore
@@ -63,7 +63,7 @@ std::unique_ptr<uint8_t[]> pad_code(bytes_view code)
 CodeAnalysis analyze_legacy(bytes_view code)
 {
     // TODO: The padded code buffer and jumpdest bitmap can be created with single allocation.
-    return {pad_code(code), code.size(), analyze_jumpdests(code)};
+    return {pad_code(code), code.size(), {}};
 }
 
 CodeAnalysis analyze_eof1(bytes_view container)

diff --git a/lib/evmone/instructions.hpp b/lib/evmone/instructions.hpp
@@ -747,12 +747,12 @@ Result sstore(StackTop stack, int64_t gas_left, ExecutionState& state) noexcept;
 /// Internal jump implementation for JUMP/JUMPI instructions.
 inline code_iterator jump_impl(ExecutionState& state, const uint256& dst) noexcept
 {
-    const auto& jumpdest_map = state.analysis.baseline->jumpdest_map;
-    if (dst >= jumpdest_map.size() || !jumpdest_map[static_cast<size_t>(dst)])
-    {
-        state.status = EVMC_BAD_JUMP_DESTINATION;
-        return nullptr;
-    }
+    // const auto& jumpdest_map = state.analysis.baseline->jumpdest_map;
+    // if (dst >= jumpdest_map.size() || !jumpdest_map[static_cast<size_t>(dst)])
+    // {
+    //     state.status = EVMC_BAD_JUMP_DESTINATION;
+    //     return nullptr;
+    // }
 
     return &state.analysis.baseline->executable_code[static_cast<size_t>(dst)];
 }