clang-tidy: Disable readability-container-data-pointer

[chfast]

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

An example: #1046.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (8e4a055) to head (401b579).
Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         153      153           
  Lines       15934    15934           
=======================================
  Hits        15012    15012           
  Misses        922      922           

Flag	Coverage Δ
eof_execution_spec_tests	17.53% <ø> (ø)
ethereum_tests	27.34% <ø> (ø)
ethereum_tests_silkpre	19.15% <ø> (ø)
execution_spec_tests	20.45% <ø> (ø)
unittests	89.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[gumb0]

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

[chfast]

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

Yea, readability.

[chfast]

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

Yea, readability.

[chfast]

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

Yea, readability.