Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track EVM stack "end" instead of "top" #895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

chfast
Copy link
Member

@chfast chfast commented May 22, 2024

No description provided.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (42a2ac7) to head (47ae17c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
- Coverage   98.50%   98.47%   -0.03%     
==========================================
  Files         130      130              
  Lines       15627    15628       +1     
==========================================
- Hits        15393    15390       -3     
- Misses        234      238       +4     
Flag Coverage Δ
ethereum-tests 27.95% <66.66%> (+<0.01%) ⬆️
ethereum-tests-silkpre 19.69% <66.66%> (+<0.01%) ⬆️
execution-spec-tests 19.05% <63.63%> (-0.01%) ⬇️
unittests 94.33% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/advanced_analysis.hpp 96.29% <100.00%> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/execution_state.hpp 96.72% <100.00%> (-0.06%) ⬇️
lib/evmone/instructions.hpp 99.36% <100.00%> (-0.64%) ⬇️

@chfast
Copy link
Member Author

chfast commented May 22, 2024

Seems no performance regressions:

Zen2, clang-18:

baseline/execute/main/blake2b_huff/empty_mean                                +0.0013         +0.0013            10            10            10            10
baseline/execute/main/blake2b_huff/8415nulls_mean                            -0.0105         -0.0105           603           597           603           597
baseline/execute/main/blake2b_shifts/8415nulls_mean                          -0.0268         -0.0268          5650          5498          5650          5498
baseline/execute/main/sha1_divs/empty_mean                                   -0.0080         -0.0080            42            42            42            42
baseline/execute/main/sha1_divs/5311_mean                                    +0.0010         +0.0010          3335          3338          3335          3338
baseline/execute/main/sha1_shifts/empty_mean                                 -0.0070         -0.0070            22            21            22            21
baseline/execute/main/sha1_shifts/5311_mean                                  -0.0081         -0.0081          1776          1761          1776          1761
baseline/execute/main/snailtracer/benchmark_mean                             -0.0088         -0.0088         29799         29538         29799         29538
baseline/execute/main/structarray_alloc/nfts_rank_mean                       -0.0136         -0.0136           396           391           396           391
baseline/execute/main/swap_math/spent_mean                                   -0.0081         -0.0081             2             2             2             2
baseline/execute/main/swap_math/received_mean                                -0.0133         -0.0133             2             2             2             2
baseline/execute/main/swap_math/insufficient_liquidity_mean                  -0.0034         -0.0034             1             1             1             1
baseline/execute/main/weierstrudel/1_mean                                    -0.0019         -0.0019           139           139           139           139
baseline/execute/main/weierstrudel/15_mean                                   -0.0119         -0.0119          1387          1370          1387          1370
OVERALL_GEOMEAN                                                              -0.0085         -0.0085             0             0             0             0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant