new(tests): Exported Evmone EOF unit tests

[hugo-dc]

🗒️ Description

• Includes python tests exported from evmone's unit tests
• Adds missing EOF Exceptions
• Consider if the tested bytecode is initcode or runtime when checking for duplicates

🔗 Related Issues

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[marioevz]

Very nice work overall!

I haven't finished the review but I thought of sharing the comments I have so far in order to start the rework earlier.

Overall general comments:

• We should reduce the number of files, since the generated test case names already contain the test file name and the test function name, many of the test cases could be placed in existing files (primarily tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_container_validation.py) without risking name collisions.
• On the new files, we should skip the test_eof1_ prefix and instead simply use test_.
• Linter is currently complaining about the format of many of the files. One simple solution is to run the black python formatting tool (see uv run black --help) on the new files.

[marioevz]

I think this file can be removed since it's very similar to tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_container_validation.py::test_invalid_containers[fork_Osaka-eof_test-single_code_section_no_data_section] with only difference being that this one uses Op.INVALID instead of Op.STOP.

[marioevz]

The linter is complaining about this.

Suggested change

	""""
	"""

[marioevz]

I think this could be done in a more pythonic way by doing a pytest.mark.parametrize of only the Opcode, then in the test function we construct the container, and that way the test's id should be automatically obtained from the Op.__name__.

Another thing is that we could (also within the test function) inspect the opcode's min_stack_height property and add some Op.PUSH0 before the opcode in order to try to trick a faulty implementation into passing the stack check (max_stack_height should be automatically calculated also, even with these opcodes that are unsupported).

Also we have this list of opcodes in tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_all_opcodes_in_container.py, it's named invalid_eof_opcodes, so we could simply use that by placing this test in that file.

[marioevz]

Once refactored, this can be renamed to something like test_deprecated_instructions.

[marioevz]

We could add another flavor to this test where the data section header is not missing, and also we have the actual body of the type section.

[marioevz]

This one is very similar to the container generated by tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_section_order.py::test_section_order[fork_Osaka-eof_test-test_position_CasePosition.BODY_AND_HEADER-section_test_SectionTest.WRONG_ORDER-section_kind_CODE]:

ef0001 010004 04 0001 02 0001 0003 00 00800001 ef3050 00

I think it should be ok to just keep that one since it forms part of the parametrization of a function already, we could remove this file.

[marioevz]

Same as previous comment, seems to be covered by tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_section_order.py::test_section_order[fork_Osaka-eof_test-test_position_CasePosition.BODY_AND_HEADER-section_test_SectionTest.WRONG_ORDER-section_kind_DATA].

[marioevz]

These are very similar to no_section_terminator* tests in tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_container_validation.py, I think we can simply add these two cases in that same file as parametrization values to test_invalid_containers

[marioevz]

These are in the same category as the invalid_first_code_section_* tests in tests/osaka/eip7692_eof_v1/eip3540_eof_v1/test_container_validation.py, but in this case I think it's enough amount of test cases to move the ones in that file into this new file.

A couple of things:

• This file could be renamed to test_first_code_section_type.py
• We could rename this test function to test_invalid_containers
• The docstring of this test function could be a bit more descriptive to account for the type of testing that is being performed.

[marioevz]

Very nice test scenarios.

Similar to previous comment, we could:

• Rename file to test_type_section_size.py
• Rename test function to test_invalid_containers
• Improve the docstring description

In general I think the test_eof1 prefix for file names in this folder is redundant since the version of EOF containers we are testing here can be implied from the parent folders' names.