Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(verkle): add parent root to witness #910

Merged
merged 4 commits into from
Oct 26, 2024
Merged

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Oct 23, 2024

🗒️ Description

Add the parent_root to the witness in the verkle fixtures.
Fixes a bug in the verkle_proof where the depthExtensionPresent field was creating non-zero padded values in some instances. These are now zero padded.

Requires this commit when fill with geth: spencer-tb/go-ethereum@1b5cd40#diff-06c63748460168e12cbf03984f37c000908e0b7ff50ca0dfe28db286a1dfd36eR395

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md N/A.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:bug Something isn't working type:feat type: Feature labels Oct 23, 2024
@jsign jsign merged commit 50ecc74 into verkle/main Oct 26, 2024
1 of 5 checks passed
@jsign jsign deleted the witness-additions branch October 26, 2024 15:54
@jsign jsign restored the witness-additions branch October 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants