salsa 3.0 #1033
Merged
salsa 3.0 #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
Fixes infinite loop in salsa debug printing
|
I'd be fine with this being merged as-is, btw. The subdiagnostic ingot thing could be addressed separately. |
|
@sbillig I took a look and it seems reasonable. With respect to the subdiagnostic ingot issue, I'm fine with merging as is and adding a followup issue as there is another related cleanup chore that needs to happen: I need to ensure that |
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Y-Nak I removed the InputIngot field from InputFile to avoid the infinite loop in the salsa object debug printing. This was a purely mechanical exercise of plumbing the appropriate InputIngot value around where it was needed in place of looking it up from the InputFile. Some of the impacted code could probably use some refactoring.
@micahscopes would you look at the latest commit's changes in the language server code? I added a
TODOabout a possibly incorrect IngotId being used for subdiagnostics. We probably need to look up the subdiagnostic's span's file's ingot manually there instead.