Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local and core ingot support. #1046

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Local and core ingot support. #1046

merged 1 commit into from
Jan 25, 2025
+840 −41

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Jan 20, 2025 •
edited
Loading

This PR implements the following:

  • resolution of ingots on disk with error handling
  • folder ingot checking (e.g. fe check my/ingot/path)
  • a core ingot that is statically loaded by default and overridable using the --core arg (e.g. fe check my/ingot/path --core my/core/ingot/path)

g-r-a-n-t
g-r-a-n-t commented Jan 21, 2025
View reviewed changes
crates/resolver/Cargo.toml Show resolved Hide resolved
crates/driver/src/lib.rs Outdated Show resolved Hide resolved
@g-r-a-n-t g-r-a-n-t force-pushed the core-local-ingots branch 5 times, most recently from b6bcc53 to ca41878 Compare January 24, 2025 17:06
g-r-a-n-t
g-r-a-n-t commented Jan 24, 2025
View reviewed changes
crates/resolver/src/ingot/config.rs Outdated Show resolved Hide resolved
crates/driver/src/db.rs Outdated Show resolved Hide resolved
crates/driver/src/db.rs Outdated Show resolved Hide resolved
library/core/config.toml Outdated Show resolved Hide resolved
crates/resolver/src/ingot.rs Outdated Show resolved Hide resolved
@g-r-a-n-t g-r-a-n-t requested a review from sbillig January 24, 2025 17:34
@g-r-a-n-t
Copy link
Member Author

@sbillig there are still a few minor things that I want to address on this PR, but it's pretty much done

@g-r-a-n-t g-r-a-n-t mentioned this pull request Jan 24, 2025
Open
4 tasks
g-r-a-n-t
g-r-a-n-t commented Jan 24, 2025
View reviewed changes
crates/driver/src/db.rs Outdated Show resolved Hide resolved
sbillig
sbillig approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a couple minor nitpicks. You'll probably run into #1049 if you add real stuff to core and try to use it.

crates/resolver/src/ingot/source_files.rs Outdated Show resolved Hide resolved
crates/resolver/src/ingot/source_files.rs Outdated Show resolved Hide resolved
@g-r-a-n-t g-r-a-n-t merged commit 0772d06 into ethereum:master Jan 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-r-a-n-t @sbillig