Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert the hashing of nodes in commit #380

Merged
merged 1 commit into from
Jul 25, 2023
Merged

revert the hashing of nodes in commit #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,17 +1571,6 @@ func (n *InternalNode) BatchSerialize() ([]SerializedNode, error) {
}
}

// TODO: we transform nodes in the first layer to HashedNodes, to avoid further calls
// to this method to do double-work. This is a temporary change for geth since in
// the current influx PBSS effort, there're still calls to Commit() storage tries
// which in VKT doesn't make sense anymore. This changes makes those calls a ~noop.
for i := range n.children {
switch n.children[i].(type) {
case *InternalNode, *LeafNode:
n.children[i] = HashedNode{}
}
}

return ret, nil
}

Expand Down
Loading