Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove replay workflow #450

Merged
merged 3 commits into from
Aug 29, 2024
Merged

ci: remove replay workflow #450

merged 3 commits into from
Aug 29, 2024

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Aug 28, 2024

We've decided to remove this workflow which did good serving before, but today:

  • We have a newer replay run on gballet/go-ethereum, but is way heavier for a CI.
  • We have test fixtures, which help to test for correctness faster/easier than doing a full replay.

Closes #399

Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
@@ -1,10 +1,7 @@
[![Go Version](https://img.shields.io/badge/go-v1.19-green.svg)](https://golang.org/dl/)
[![Lint and Test](https://github.com/ethereum/go-verkle/actions/workflows/go.yml/badge.svg)](https://github.com/ethereum/go-verkle/actions/workflows/go.yml)
[![DeepSource](https://deepsource.io/gh/ethereum/go-verkle.svg/?label=active+issues&show_trend=true&token=OjuF5Q2HbKzpWY8LgWuffNZp)](https://deepsource.io/gh/ethereum/go-verkle/?ref=repository-badge)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gballet, it looks like this badge is broken.

Rendered README:
image

I had removed this, but if you think this is a mistake due to some misconfiguration of Deepsource or something maybe you want to check out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it seems to have been broken when we moved to the ethereum org, or maybe I just didn't accept the new permissions. I asked the org to add it back, let's see what they say.

@jsign jsign requested a review from gballet August 28, 2024 11:40
@jsign jsign marked this pull request as ready for review August 28, 2024 11:40
Signed-off-by: Ignacio Hagopian <[email protected]>
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this. The deepsource one needs some external help, I'm not going to hold this PR for it. I will add a tracking issue.

@gballet gballet merged commit dffa756 into master Aug 29, 2024
7 checks passed
@gballet gballet mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the CI replay action
2 participants