Matrix refactor for circleci config: #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
leverage-matrix-to-simplify-circleci-config
branch
9 times, most recently
from
7f4d0f8 to
0609bae
Compare
fselmo
force-pushed
the
leverage-matrix-to-simplify-circleci-config
branch
3 times, most recently
from
15ece89 to
42c6bf1
Compare
- Leverage matrix to simplify circleci config - Update ``update_geth.py`` script to account for these changes
fselmo
force-pushed
the
leverage-matrix-to-simplify-circleci-config
branch
from
42c6bf1 to
c6dcadd
Compare
|
I'm done with updates here. Ready for review. |
kclowes
approved these changes
Jan 13, 2025
I'll see what a bare bones generalized version of this looks like for most repos since they would have very similar tests 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The circleci config is way too lengthy for every python version support. If we can, we should consolidate it.
How was it fixed?
matrixdesign pattern to DRY up the configupdate_geth.pyscript to account for these changesTodo:
Cute Animal Picture