Code

Refactoring the Codebase#35

Code

Open

Bhargavasomu wants to merge 11 commits intoethereum:mainethereum/py_ecc:mainfrom Bhargavasomu:refactorBhargavasomu/py_ecc:refactorCopy head branch name to clipboard

+2,352-2,649

Commits

Commits on Dec 14, 2018

• Refactor codebase with BaseCurve and Properties Dict

  Bhargavasomu

  committed
  1a66554

  Copy full SHA for 1a66554

• Modify tests as per the refactored API

  Bhargavasomu

  committed
  1e077ce

  Copy full SHA for 1e077ce

• Update pytest version in setup

  Bhargavasomu

  committed
  b3f0192

  Copy full SHA for b3f0192

• Add type hinting for entire module

  Bhargavasomu

  committed
  d89bee8

  Copy full SHA for d89bee8

Commits on Dec 16, 2018

• Update all the BaseCurve methods to either staticmethod or classmethod

  Bhargavasomu

  committed
  c4707c9

  Copy full SHA for c4707c9

• Add instance objects of curves as part of API usage

  Bhargavasomu

  committed
  b1330b7

  Copy full SHA for b1330b7

• Replace some asserts with exceptions

  Bhargavasomu

  committed
  e502901

  Copy full SHA for e502901

• Add validation of constants at the time of import

  Bhargavasomu

  committed
  00e65a8

  Copy full SHA for 00e65a8

Commits on Dec 17, 2018

• Add TypedDict to install_requires

  Bhargavasomu

  committed
  10e89d8

  Copy full SHA for 10e89d8

Commits on Dec 18, 2018

• Further replace all the assertions with exceptions

  Bhargavasomu

  committed
  12dfa2f

  Copy full SHA for 12dfa2f

• Make curve_properties of type NamedTuple instead of TypedDict

  Bhargavasomu

  committed
  9a17072

  Copy full SHA for 9a17072