Udapp disconnect fix #5639
Merged
Udapp disconnect fix #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
udapp-disconnect-fix
branch
from
554e3f3 to
89971a1
Compare
LianaHus
reviewed
Jan 15, 2025
| @@ -235,6 +235,16 @@ export function RunTabUI(props: RunTabProps) { | |||
| } | |||
| }, [runTab.popup]) | |||
|
|
|||
| useEffect(() => { | |||
| if (runTab.selectExEnv.includes('injected') && | |||
There was a problem hiding this comment.
I am not sure I understand what you mean by wallets.
LianaHus
reviewed
Jan 15, 2025
| Object.entries(runTab.accounts.loadedAccounts).length === 0 && | ||
| runTab.accounts.selectedAccount.length > 0) { | ||
| // switch to vm-cancum because no account is loaded from injected provider | ||
| const context = plugin.blockchain.defaultPinnedProviders[0] // vm-cancun |
There was a problem hiding this comment.
can we load load the previously selected or it will be difficult to do?
There was a problem hiding this comment.
It would just require some more code to track any account that is selected and persist it outside the reach of a useEffect.
Aniket-Engg
force-pushed
the
udapp-disconnect-fix
branch
from
7c0359b to
1170da2
Compare
2 tasks
LianaHus
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5483