Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor & allow saving already forked state #5754

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

refactor & allow saving already forked state #5754

wants to merge 9 commits into from

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Feb 11, 2025 •
edited
Loading

partially_fix #5611

  • refactor: set a config property instead of having all the properties flat.
  • refactor the Provider type.
  • add a new property: isRpcForkedState, statePath and isVMStateForked.
  • allow to fork an already forked state.

@netlify Netlify
Copy link

netlify bot commented Feb 11, 2025 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 37ae386
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67adf30b3223db00083134be
😎 Deploy Preview https://deploy-preview-5754--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 requested a review from Aniket-Engg February 11, 2025 11:56
Aniket-Engg
Aniket-Engg reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forking a forked state shows default name like vm-fs-vm-cancun_1739284202768_1739284255625 , this should be improved

@yann300 yann300 requested a review from Aniket-Engg February 12, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann300 @Aniket-Engg