Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop swarmhash support #147

Merged
merged 4 commits into from
May 15, 2024
Merged

Drop swarmhash support #147

merged 4 commits into from
May 15, 2024

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Apr 30, 2024

This PR removes support for swarm hashes from the binary releases list and updates the Node.js dependency to its latest version in the CI.

Additionally, the PR updates the GitHub Actions to utilize their latest versions. Some of them, such as https://github.com/actions/download-artifact and https://github.com/actions/upload-artifact, were utilizing deprecated versions. Only actions maintained by Github were updated.

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. [Learn more.](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/)
Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions.
This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.

Fixes ethereum/solidity#14700

OKEAMAH

This comment was marked as spam.

OKEAMAH

This comment was marked as spam.

Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

Like I said on the call, the fact that the position of the IPFS hash changes is a potential problem. But these hashes are probably not that widely used anyway, so I think we can still do it without affecting most tools. We could insert null in place of Swarm's hash, but tools should recognize these URLs based on the protocol and not rely on the position anyway.

Please remember to update the docs though.

@cameel
Copy link
Member

cameel commented May 10, 2024

By the way, the PR probably needs an update before we merge it, to account for nightlies that were added in the meantime. I rebased it, but now it will probably fail because of those nightlies.

@cameel
Copy link
Member

cameel commented May 10, 2024

Note that if you come back to this PR tomorrow or later, you'll need to remember to rebase again before merging since we'll have a new nightly by then :)

@r0qs r0qs merged commit a074ec3 into gh-pages May 15, 2024
7 checks passed
@r0qs r0qs deleted the drop-swarmhash-support branch May 15, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility between swarmhash and node.js > 16 makes releases difficult
3 participants