-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop swarmhash support #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it.
Like I said on the call, the fact that the position of the IPFS hash changes is a potential problem. But these hashes are probably not that widely used anyway, so I think we can still do it without affecting most tools. We could insert null
in place of Swarm's hash, but tools should recognize these URLs based on the protocol and not rely on the position anyway.
Please remember to update the docs though.
b65ac56
to
e2063ef
Compare
By the way, the PR probably needs an update before we merge it, to account for nightlies that were added in the meantime. I rebased it, but now it will probably fail because of those nightlies. |
Note that if you come back to this PR tomorrow or later, you'll need to remember to rebase again before merging since we'll have a new nightly by then :) |
e2063ef
to
6df9c3f
Compare
This PR removes support for swarm hashes from the binary releases list and updates the Node.js dependency to its latest version in the CI.
Additionally, the PR updates the GitHub Actions to utilize their latest versions. Some of them, such as https://github.com/actions/download-artifact and https://github.com/actions/upload-artifact, were utilizing deprecated versions. Only actions maintained by Github were updated.
Fixes ethereum/solidity#14700