Sort pre-0.4.0 versions properly #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
changed the title
|
@cameel while this is definitely not a pressing issue, perhaps we may want to get this done? |
cameel
reviewed
May 10, 2021
This comment has been minimized.
This comment has been minimized.
They definitely existed, hence the PR.
Hmm, I think we should have the proper history, especially as we now serve this off-github. |
OK then. Here's a PR that restores them: #103. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Beregszaszi <[email protected]> Co-authored-by: Kamil Śliwak <[email protected]>
r0qs
approved these changes
Dec 8, 2022
r0qs
reviewed
Dec 14, 2022
Comment on lines
+16
to
+20
| "path": "solc-emscripten-wasm32-v0.3.6-workaround+commit.3fc68da5.js", | ||
| "version": "0.3.6", | ||
| "prerelease": "workaround", | ||
| "build": "commit.3fc68da5", | ||
| "longVersion": "0.3.6-workaround-workaround+commit.3fc68da5", |
There was a problem hiding this comment.
@cameel although the tests passed, I noticed one weird case here though. So please do not approve it yet. It seems that the symlink is being created with the -workaround and then the longVersion get it doubled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the sorting order for <0.4.0 -- which was changed by #8.