-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add github action to update remote docker images on a new tag push #1595
Open
ogenev
wants to merge
1
commit into
ethereum:master
Choose a base branch
from
ogenev:update-docker-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
name: Update Docker Image Tag from "latest" to 'testnet' | ||
|
||
on: | ||
workflow_dispatch: # Allows manual triggering of the workflow | ||
push: | ||
tags: | ||
- v* | ||
|
||
jobs: | ||
retag-and-push: | ||
name: Retag and Push Docker Image | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
# Step 1: Log in to Docker Hub | ||
- name: Log in to Docker Hub | ||
uses: docker/login-action@v2 | ||
with: | ||
username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
password: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
|
||
# Step 2: Pull the latest images | ||
- name: Pull Docker images | ||
run: | | ||
docker pull portalnetwork/trin:latest | ||
docker pull portalnetwork/trin:latest-bridge | ||
|
||
# Step 3: Retag the images | ||
- name: Retag Docker images | ||
run: | | ||
docker image tag portalnetwork/trin:latest portalnetwork/trin:testnet | ||
docker image tag portalnetwork/trin:latest-bridge portalnetwork/trin:bridge | ||
|
||
# Step 4: Push the new tags to Docker Hub | ||
- name: Push new tags to Docker Hub | ||
run: | | ||
docker push portalnetwork/trin:testnet | ||
docker push portalnetwork/trin:bridge |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still release
alpha
versions. Meaning, next release should probably be:v0.1.1-alpha.1
.And once we achieve milestone or want to make proper release for whatever reason, we release non-alpha (
v0.1.1
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think two approaches are viable here:
I'm more in favor of the second approach.