-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PortalNetwork: REPL Interface for Portal Network #721
base: master
Are you sure you want to change the base?
Conversation
@acolytec3 I just want to make sure I'm in the right track. Please your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. I pushed a couple of tweaks so it will actually connect to the network now. You can also tune the logs it shows because the stuff you have now is a lot of logs.
Alright. Also, the methods I implemented so far are as a result of what I saw from here Are there more stuff I could have done there? |
The full rpc spec is here I don't think we need to implement all of them but maybe like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need a different (more accurate) mechanism for enforcing "first ping is type 0", maybe through an enr cache that we've played around with in the past.
This PR introduces a REPL interface for interacting with the Portal Network, enabling developers to test and manage the network more effectively.
Features:
REPL Commands:
.ping <network>
: Send a ping request to the specified network (history
orstate
)..findnodes <network> <enr> <distances>
: Locate nodes within a network using an ENR and distances..findcontent <network> <enr> <contentKey>
: Search for content in a network using an ENR and content key..offer <network> <enr> <contentKey> <contentValue>
: Offer content to a node in the specified network..status
: Display the current status of the Portal Network and its components.