fix: fix too early initialization of bee dashboard component (#95) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechsimetka
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Good job, tested and it works great.
Yeah we found this re-render issue in bee-dashboard and tried to resolve it (not identifying the problem in swarm-gateway). It is likely that in the latest version of the app it works (this should have fixed it ethersphere/bee-dashboard#277 )
|
@vojtechsimetka @nugaon BeeDashboard is now updated to the latest version, and the error is gone. |
vojtechsimetka
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One part of the issue is that the BeeDashboard component is initialized before the actual values for bee host and bee debug host are loaded. That causes the BeeDashboard component to start with wrong host values. But I noticed even after fixing this issue that the same issue is still present, but inside the BeeDashboard. Even when it receives correct values on first render, it still initializes state with
localhostand then later it updates it with correct values.