Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec to reth command #262

Closed
wants to merge 2 commits into from
Closed

Conversation

eskp
Copy link
Contributor

@eskp eskp commented Dec 4, 2023

Without exec the shell spawns a new child process to run the command. So then when we send the container a kill signal, for example when rolling out a new deployment, reth process doesn't get this signal. So then Pod just sits in "Terminating" until timed out.

@eskp eskp requested a review from skylenet as a code owner December 4, 2023 02:06
@barnabasbusa
Copy link
Collaborator

@eskp pls bump the version of reth + bump the version in ethereum-node, then run make docs from the root, and add this to the PR.

@eskp
Copy link
Contributor Author

eskp commented Dec 14, 2023

done @barnabasbusa , thanks

@barnabasbusa
Copy link
Collaborator

Closing in favor of: #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants