Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy multiple op l2s #20

Merged
merged 43 commits into from
Jun 18, 2024
Merged

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Jun 11, 2024

Enables configuring and deploying multiple l2s on top of the same l1. The biggest difference is splitting up contract deployment to deploy factory contract in a separate run_sh once.
example config:

ethereum_package:
  participants:
    - el_type: geth
    - el_type: reth
  network_params:
    preset: minimal
optimism_package:
  - participants:
      - el_type: op-geth
    additional_services:
      - blockscout
    network_params:
      name: op-rollup-one
      network_id: "3151909"
  - participants:
      - el_type: op-geth
    network_params:
      name: op-rollup-two
      network_id: "3151910"
    additional_services:
      - blockscout

network_params.yaml Outdated Show resolved Hide resolved
network_params.yaml Outdated Show resolved Hide resolved
network_params.yaml Outdated Show resolved Hide resolved
network_params.yaml Outdated Show resolved Hide resolved
network_params.yaml Outdated Show resolved Hide resolved
network_params.yaml Outdated Show resolved Hide resolved
network_params.yaml Outdated Show resolved Hide resolved
src/contracts/contract_deployer.star Outdated Show resolved Hide resolved
src/contracts/contract_deployer.star Show resolved Hide resolved
main.star Outdated Show resolved Hide resolved
Co-authored-by: Barnabas Busa <[email protected]>
Signed-off-by: Tedi Mitiku <[email protected]>
kurtosis.yml Outdated Show resolved Hide resolved
@barnabasbusa
Copy link
Contributor

Could you please revert to use ethereum_package and optimism_package instead of l1, l2s ?

@barnabasbusa
Copy link
Contributor

Can you please rebase over latest main branch?

@tedim52 tedim52 changed the title deploy multiple op l2s feat: deploy multiple op l2s Jun 17, 2024

Args:
args(yaml): Configures other aspects of the environment.
args(json): Configures other aspects of the environment.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, our package indexer only picks up json (you can still pass it in as yaml but starlark converts it to json) so in order for the package to show up in package catalog, has to be set to json instead of yaml. I can update package indexer to support yaml type as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which package indexer?

@tedim52 tedim52 requested a review from barnabasbusa June 17, 2024 20:05
@barnabasbusa barnabasbusa enabled auto-merge June 18, 2024 12:08
@barnabasbusa barnabasbusa merged commit 5bb15fa into ethpandaops:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants