Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add op-erigon #30

Closed

Conversation

mininny
Copy link
Contributor

@mininny mininny commented Jun 17, 2024

Resolves #12

This PR adds op-erigon to the list of execution clients for optimism protocol.
Most of the configuration is same as op-geth and op-reth, except for erigon run flags and op-erigon's docker image.

@mininny mininny mentioned this pull request Jun 17, 2024
@barnabasbusa
Copy link
Contributor

Could you please rebase the latest main branch changes?

@mininny mininny force-pushed the feature/mininny/add-op-erigon branch from 57d5fac to ce03802 Compare June 18, 2024 13:22
@barnabasbusa
Copy link
Contributor

I could help you finishing up this PR if you enable write access by maintainers. Currently I can't push to your PR.

@barnabasbusa
Copy link
Contributor

barnabasbusa commented Jun 19, 2024

Looks like you have tried to reuse the erigon flags, instead of op-erigon flags.
some ws related flags don't' seem to exist in op-erigon, but they exist in erigon.

        "--ws.addr=0.0.0.0",
        "--ws.api=admin,engine,net,eth,web3,debug",
        "--ws.origins=*",
        "--discovery.port={0}".format(discovery_port),

@mininny mininny marked this pull request as ready for review June 19, 2024 13:44
@barnabasbusa
Copy link
Contributor

Closing in favor of #38

@mininny
Copy link
Contributor Author

mininny commented Jun 19, 2024

I could help you finishing up this PR if you enable write access by maintainers. Currently I can't push to your PR.

I'm sorry, I didn't have time today to work on this. I was trying to give you access, but it seems like "Allow edits by maintainers" doesn't seem to be enabled because of this issue: https://github.com/orgs/community/discussions/5634. Thanks for the new pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OP-Erigon
2 participants