Skip to content

Commit

Permalink
Merge pull request #13 from ethpandaops/fix/output-max-export-batch-size
Browse files Browse the repository at this point in the history
fix(sentry): http max_export_batch_size config name
  • Loading branch information
Savid authored Nov 14, 2022
2 parents ac5986d + 249d837 commit b984936
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions example_sentry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ outputs:
ntp_server: pool.ntp.org
headers:
Authorization: Someb64Value
max_queue_size: 2048
max_queue_size: 51200
batch_timeout: 5s
export_timeout: 30s
batch_interval_seconds: 512
max_export_batch_size: 512
4 changes: 2 additions & 2 deletions pkg/sentry/output/http/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import (
type Config struct {
Address string `yaml:"address"`
Headers map[string]string `yaml:"headers"`
MaxQueueSize int `yaml:"max_queue_size" default:"2048"`
MaxQueueSize int `yaml:"max_queue_size" default:"51200"`
BatchTimeout time.Duration `yaml:"batch_timeout" default:"5s"`
ExportTimeout time.Duration `yaml:"export_timeout" default:"30s"`
MaxExportBatchSize int `yaml:"batch_interval_seconds" default:"512"`
MaxExportBatchSize int `yaml:"max_export_batch_size" default:"512"`
}

func (c *Config) Validate() error {
Expand Down
4 changes: 2 additions & 2 deletions pkg/sentry/output/processor/batch.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type EventExporter interface {

// Defaults for BatchDecoratedEventProcessorOptions.
const (
DefaultMaxQueueSize = 2048
DefaultMaxQueueSize = 51200
DefaultScheduleDelay = 5000
DefaultExportTimeout = 30000
DefaultMaxExportBatchSize = 512
Expand All @@ -55,7 +55,7 @@ type BatchDecoratedEventProcessorOption func(o *BatchDecoratedEventProcessorOpti
type BatchDecoratedEventProcessorOptions struct {
// MaxQueueSize is the maximum queue size to buffer events for delayed processing. If the
// queue gets full it drops the events.
// The default value of MaxQueueSize is 2048.
// The default value of MaxQueueSize is 51200.
MaxQueueSize int

// BatchTimeout is the maximum duration for constructing a batch. Processor
Expand Down

0 comments on commit b984936

Please sign in to comment.