-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Results.txt #132
base: testing
Are you sure you want to change the base?
Create Results.txt #132
Conversation
Thanks a lot for the testing. Do we need any changes to get this correct result? Or sometimes it is correct, while sometimes not? |
I will run the test a few more times to confirm the results. When I ran your test script with 20 nodes, I found that there were peers/topic peers ranging from 17-20. When running 10 nodes with ours, we found no gaps. I will run 10 and 20 nodes a few times and confirm! |
Hey @mhchia mhchia, running the tests again when using the image from the master branch, I get some strange results..
The nodes are all connecting to the bootnode (as the bootnode's peerlist is full) but the peerlist of the rest of the nodes only contains the bootnode's address. |
Using the image on the mhchia branch gives this as the result:
Looks like the results are nice here. Can you let me know which branch is the most up-to-date? |
@araskachoi Sorry for this issue! We should use the image of the master branch. I am rebasing the test case back to master in #135, and therefore no need to use my previous branch. |
@mhchia no problem. But make sure that the source code from your branch is the one being pushed. That was the one that worked for me when i was building out the containers and application |
Changed the base to |
@araskachoi Does it need modifying? I can merge it if it doesn't need modifications. |
This was from the older commit.
This is from the latest testing branch (1 bootnode, 10 client nodes)
|
@araskachoi Awesome! Would you mind updating them in the Results.txt in this PR so that i can merge them? Sorry that I'm not sure of the format so couldn't help to update it. |
Results of testing 10 nodes.