Parameterize the flight stack for MAVROS #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduce some code duplication Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
changed the title
Jaeyoung-Lim
requested changes
Feb 19, 2024
* Only PX4 works right now * When ArduPilot also works, the default can be removed Signed-off-by: Ryan Friedman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow launching MAVROS configured for either ArduPilot or PX4 configuration through launch arguments.
Benefits
Don't need to comment/uncomment code to change which is used
Cost
Code duplication with the Node object. There may be cleaner ways to do this, but it's better than before.
Details
I think we can use an if_condition to launch either PX4 or ArduPilot. Just have to figure out how to do that without duplicating the Node object.