Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flight stack combo box to planning panel #45

Merged

Conversation

srmainwaring
Copy link
Collaborator

@srmainwaring srmainwaring commented Feb 20, 2024

Add a flight stack combo box to the planning panel. This is to allow the commands issued by the Engage Planner and Disengage Planner buttons to be customised to each flight stack.

Button PX4 ArduPilot
Engage OFFBOARD GUIDED
Disengage AUTO.RTL RTL

Figure: flight stack combo box in rviz
rviz_flight_stack_selector

Alternatives

An alternative would be to subscribe to mavros topic advertising the flight stack and use this instead of the combo. Setting the choice in the GUI seemed more straightforward and provides visible feedback of the choice made.

@srmainwaring srmainwaring added the enhancement New feature or request label Feb 20, 2024
@srmainwaring srmainwaring force-pushed the prs/prs-rviz-flight-stack-selector branch from 3259f48 to 9956a3e Compare February 20, 2024 17:58
- The commands used by engage planner and disengage planner buttons are flight stack specific

Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring force-pushed the prs/prs-rviz-flight-stack-selector branch from 9956a3e to 446752f Compare February 20, 2024 18:03
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@srmainwaring srmainwaring merged commit 3c94e73 into ethz-asl:ros2 Feb 21, 2024
3 checks passed
@srmainwaring srmainwaring deleted the prs/prs-rviz-flight-stack-selector branch February 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants