[review] tree wide: CFG_INSECURE deprecates CFG_WARN_INSECURE

Refines sanity tests CFG_WARN_INSECURE.

Signed-off-by: Etienne Carriere <[email protected]>

mk/config.mk

@@ -919,12 +919,16 @@ $(eval $(call cfg-enable-all-depends,CFG_REGULATOR_FIXED, \
 # they've finalized implementing stubbed functionality (see OP-TEE
 # documentation/Porting guidelines) as well as vendor specific security
 # configuration.
-CFG_INSECURE ?= y
-
+#
 # CFG_WARN_INSECURE served the same purpose as CFG_INSECURE but is deprecated.
-ifneq (,$(CFG_WARN_INSECURE))
-$(error CFG_WARN_INSECURE is deprecated, please use CFG_INSECURE instead)
+ifneq (undefined,$(flavor CFG_WARN_INSECURE))
+$(info WARNING: CFG_WARN_INSECURE is deprecated, use CFG_INSECURE instead)
+CFG_INSECURE ?= $(CFG_WARN_INSECURE)
+ifneq ($(CFG_INSECURE),$(CFG_WARN_INSECURE))
+$(error Inconsistent CFG_INSECURE=$(CFG_INSECURE) and CFG_WARN_INSECURE=$(CFG_WARN_INSECURE))
 endif
+endif # CFG_WARN_INSECURE defined
+CFG_INSECURE ?= y
 
 # Enables warnings for declarations mixed with statements
 CFG_WARN_DECL_AFTER_STATEMENT ?= y