Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for files in ftp servers #30

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Add support for files in ftp servers #30

merged 5 commits into from
Jan 19, 2023

Conversation

GtheSheep
Copy link
Contributor

Let me know if you think this should be merged with the function for SFTP files?

Also there's a bit of a temp solution to just hide credentials from the path as mentioned in #22 - happy to switch this to something better then just replacing with empty strings if you have a preference for how it should work?

@menzenski
Copy link
Collaborator

Let me know if you think this should be merged with the function for SFTP files?

IMO this is fine to keep separate.

Also there's a bit of a temp solution to just hide credentials from the path as mentioned in #22 - happy to switch this to something better then just replacing with empty strings if you have a preference for how it should work?

Thanks for adding this masking - this is maybe a nit, but I wonder if it'd be preferable to replace with asterisks: like re.sub('sftp://.*?@', "********", path, flags=re.DOTALL) - maybe that'd be more understandable to consumers?

@GtheSheep
Copy link
Contributor Author

@menzenski - Ah yeah good call, I think that makes it clearer that masking has occurred rather than an error in reading credentials, will update

@menzenski menzenski merged commit 34f135b into ets:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants