This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Added client/server specific memcached connection counts #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added columns for client vs server key accesses
Added sorting for server and client calls
…rics collection to check for client AND server, not just client or server
Cleaned up code that sets default server/client values
Updated documentation
Added ip address acquisition and option to override
|
Thanks for the contribution Jason, i'm still poking around these changes which are great. I've got a couple ideas for features we've been talking about internally that fit nicely with the work you've done so I might merge this onto a feature branch and we can collaborate if you're keen. Will keep this thread updated. |
|
Jason, great work. I'm gonna merge these patches onto a branch and test this feature. Great! ;) |
|
Awesome, let me know if there's anything I can do to help. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run memcached on servers that serve to multiple machines, and also runs a local client software that makes queries outbound to local or other memcached servers. mctop does not differentiate between an incoming request to the memcached instance, or an outgoing request from the client. I've added the optional flag -c or --detailed-calls which also provides a breakdown of the calls by client or server, enabled sorting of these columns, and added an option -i or --ip-address that allows the user to specify which ip memcached is listening on (by default it uses the local gateway ip address).
This has been very helpful to us in troubleshooting issues to make sure we're focusing on the proper keys, I thought it might be useful for others. I'm happy to make changes or adjustments if necessary.
Jason