Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial adaptation of SymCC Runtime to be usable as a standalone library. #1

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

rmalmain
Copy link
Collaborator

@rmalmain rmalmain commented Apr 4, 2024

There are also some minor improvements to CMakeLists in general.

Some points that should be validated:

  • cmake minimum version. It seems like a reasonable choice considering cmake versions in most modern distributions
  • the readme & licensing. I think it's in a somewhat correct state for a first draft, but improvements are welcome.

What's missing:

  • CI/CD integration.

…ary.

Some improvements to the various CMakeLists have also been integrated.
@rmalmain
Copy link
Collaborator Author

rmalmain commented Apr 4, 2024

Also, I did not clean the documentation part; there are some parts that should still be in SymCC and others that correspond to symcc-rt.

Copy link
Collaborator

@sebastianpoeplau sebastianpoeplau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 😊

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/Backends.txt Outdated Show resolved Hide resolved
minor (presentation)
Copy link
Member

@aurelf aurelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments in the review. Looks great :)

.gitignore Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/Backends.txt Outdated Show resolved Hide resolved
@aurelf aurelf merged commit f8a0345 into main Apr 9, 2024
@aurelf
Copy link
Member

aurelf commented Apr 9, 2024

Merged thanks all !

@rmalmain rmalmain deleted the export_symcc_runtime branch April 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants