-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update years in the licence statements #55
base: master
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,6 @@ | |||
# | |||
# This file is part of the efc project <https://github.com/eurus-project/efc/>. | |||
# Copyright (c) 2024 The efc developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need braces and a comma? Also there is no reason to capitalise "present".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen that structure in some device drivers provided by some very popular vendors (like NXP Semiconductors). I think that comma gives additional "focus" to the developers that work on the specific file. Capitalization of the word 'present' was totally up to me at the moment of writing this, I don't have specific reason for that, I will change it.
Thanks for working on this, it seems like a good solution so we don't have to update the file headers all the time. I'm not sure on the legality of it though, we have to check if it has some licensing implications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Can you help me check this licensing implications, I am totally unexperienced with this. Thanks in advance! |
In order to resolve the issue opened by @lkijanovic : [(https://github.com//issues/46)] This PR presents my proposal for a solution. The idea is to put a date in form (year - Present), where year represents the year when file has been created. The word Present would serve as a placeholder for a year when some stable version of this project would be published. Please note that this is just my proposal, and that I am glad to hear another ideas.