Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kdtree class to irtgraph.l #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

garaemon
Copy link
Contributor

@garaemon garaemon commented Jul 5, 2015

No description provided.

@k-okada
Copy link
Member

k-okada commented Jul 5, 2015

is this copied from euslib?

@garaemon garaemon force-pushed the kd-tree branch 2 times, most recently from 564eb1f to 831d220 Compare July 5, 2015 06:31
@garaemon
Copy link
Contributor Author

garaemon commented Jul 5, 2015

Yes

@k-okada
Copy link
Member

k-okada commented Jul 9, 2015

  • better to have test code
  • is there any example to use kdtree with pointcloud/mesh/... data?

◉ Kei Okada

On Sun, Jul 5, 2015 at 3:31 PM, Ryohei Ueda [email protected]
wrote:

Yes


Reply to this email directly or view it on GitHub
#225 (comment).

@@ -0,0 +1,427 @@
#pragma init (register_cvoxel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be #pragma init (register_ckdtree) ?

CC: @iory

@iory
Copy link
Contributor

iory commented Feb 27, 2018

I would like to add kd-tree to jskeus.
Should we use ANN or FLANN library?

@k-okada
Copy link
Member

k-okada commented Feb 27, 2018

we should add test/example code

@iory
Copy link
Contributor

iory commented Feb 28, 2018

@k-okada

Of course I understand that.
This PR does have not implemented kdtree's algorithm.
Following functions's implementation
https://github.com/garaemon/jskeus/blob/17484d05d0787ce1dc316f000bcb9e3c50858d60/irteus/ckdtree.c#L17-L21

I will add implementation of these.
Which is better, using library like FLANN or implementation by euslisp?

@furushchev
Copy link
Member

@iory Searching with keyword 'kdtree_init', I found: https://github.com/jsk-ros-pkg/euslib/blob/a2ed067c10fdac0179f23e5fb758bb0a460b918f/jsk/CANN.C .
Can we re-use this? (it looks it uses FLANN internally, so we need to let jskeus depends on FLANN library.)

Cc: @k-okada

@k-okada
Copy link
Member

k-okada commented Feb 28, 2018 via email

@furushchev
Copy link
Member

@k-okada He means kdtree implementation is originally located at https://github.com/jsk-ros-pkg/euslib/blob/a2ed067c10fdac0179f23e5fb758bb0a460b918f/jsk/CANN.C separately from cKdTree.c in former jskeusgl and not is NOT included in this pull request (maybe @garaemon forgot to git add the file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants