-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed format of input file to csv with headers (required) #14
base: main
Are you sure you want to change the base?
Conversation
@@ -1,3 +1,4 @@ | |||
mels|pitch|text | |||
wavs/LJ045-0096.wav|pitch/LJ045-0096.pt|Mrs. De Mohrenschildt thought that Oswald, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these files should then also be updated to use absolute paths
@@ -193,26 +193,25 @@ def __init__(self, | |||
|
|||
assert not (load_pitch_from_disk and self.pitch_tmp_dir is not None) | |||
|
|||
if len(self.audiopaths_and_text[0]) < expected_columns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we still do some kind of check on expected number of columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh lol, I commented on this across 2 PRs
else: | ||
spk = 0 | ||
|
||
if self.load_pitch_from_disk: | ||
pitchpath = fields[0] | ||
pitchpath = self.audiopaths_and_text[index]['pitch'] | ||
pitch = torch.load(pitchpath) | ||
if self.pitch_mean is not None: | ||
assert self.pitch_std is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting here because I can't do it lower down but what about the TTSCollate call function?
I guess that's to do with the return type if getitem returning a tuple?
@@ -287,15 +286,15 @@ def get_prior(self, index, mel_len, text_len): | |||
return attn_prior | |||
|
|||
def get_pitch(self, index, mel_len=None): | |||
audiopath, *fields = self.audiopaths_and_text[index] | |||
audiopath = self.audiopaths_and_text[index]['mels'] | |||
|
|||
if self.n_speakers > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of interest, where is this spk used? Afaik it's not currently used here, though I imagine the intention is to have different mean and std?
@johannahom I'll test just this branch in an existing setup (without the conditioning), however that still leaves the issue of what paths to use in these paths shared by everyone |
works |
See new input file as examples.