Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump alliance and fix proto annotation #206

Merged
merged 3 commits into from
May 6, 2024

Conversation

minhngoc274
Copy link
Contributor

@minhngoc274 minhngoc274 commented May 4, 2024

Fix #194

Summary by CodeRabbit

  • Refactor
    • Improved internal parameter management for enhanced system performance and reliability.

Copy link
Contributor

coderabbitai bot commented May 4, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent modifications in the code primarily involve the removal of the //nolint:staticcheck directive and reaffirming the assignments of the ParamKeyTable for various modules in the app/upgrades.go file. This adjustment enhances code cleanliness and adherence to best practices in static analysis.

Changes

File Path Change Summary
app/upgrades.go Removed //nolint:staticcheck, updated ParamKeyTable assignments for multiple modules

🐰✨
Oh, in the land of code and key,
Changes bloom like flowers, see!
No lint to dodge, no checks to flee,
Clean as a whistle, our code shall be!
Hop, hop, hurray, to cleaner spree! 🌼🎉
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@minhngoc274 minhngoc274 requested a review from hoank101 May 4, 2024 08:37
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@minhngoc274 minhngoc274 force-pushed the ngoc/alliance-proto-annotation branch from 155a4b8 to bb8ae34 Compare May 4, 2024 08:49
@minhngoc274
Copy link
Contributor Author

minhngoc274 commented May 4, 2024

I've used my latest update base on terra-classic/alliance/release/v0.4.x notional-labs/alliance@9fb9606

@minhngoc274 minhngoc274 self-assigned this May 4, 2024
@faddat
Copy link
Contributor

faddat commented May 4, 2024

Nice, have you made a PR to the tfl repo also?

@hoank101 hoank101 changed the title fix: alliance proto annotation deps: bump alliance and fix proto annotation May 6, 2024
@hoank101
Copy link
Contributor

hoank101 commented May 6, 2024

why not use the original repo? https://github.com/terra-money/alliance/releases/tag/v0.4.3

@minhngoc274
Copy link
Contributor Author

PR created here terra-money/alliance#360. I will change once it have been merge

Copy link
Contributor

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoank101
Copy link
Contributor

hoank101 commented May 6, 2024

thank you for PR

@hoank101 hoank101 merged commit 67597bd into main May 6, 2024
10 checks passed
@hoank101 hoank101 deleted the ngoc/alliance-proto-annotation branch May 6, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not have proto annotation
3 participants